[5.7] SILGen: Don't reference external property descriptors for @_alwaysEmitIntoClient properties. #59214
+59
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tIntoClient properties. Their definition is fully visible to clients to be copied into them, and there isn't necessarily a symbol for the property descriptor in the defining module, so it isn't necessary or desirable to try to use a property descriptor with them. Trying to reference the descriptor leads to missing symbol errors at load time when trying to use keypaths with older versions of the defining dylib, which goes against the purpose of `@_alwaysEmitIntoClient` meaning "no ABI liabilities for the defining module". Fixes rdar://94049160.
|
@swift-ci Please test |
tbkka
approved these changes
Jun 2, 2022
DougGregor
approved these changes
Jun 2, 2022
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 17, 2023
…ed properties. The property descriptors of `@backDeployed` properties aren't available on OSes prior to the "back deployed before" OS version, so the descriptors cannot be referenced by clients that may run against older versions of the library that defines the property. See swiftlang#59214 for prior art. Resolves rdar://106517386
This was referenced Aug 17, 2023
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 17, 2023
…ed properties. The property descriptors of `@backDeployed` properties aren't available on OSes prior to the "back deployed before" OS version, so the descriptors cannot be referenced by clients that may run against older versions of the library that defines the property. See swiftlang#59214 for prior art. Resolves rdar://106517386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their definition is fully visible to clients to be copied into them, and there isn't necessarily
a symbol for the property descriptor in the defining module, so it isn't necessary or desirable to
try to use a property descriptor with them. Trying to reference the descriptor leads to missing
symbol errors at load time when trying to use keypaths with older versions of the defining dylib,
which goes against the purpose of
@_alwaysEmitIntoClientmeaning "no ABI liabilities for thedefining module". Fixes rdar://94049160.