SILGen: Don't reference external property descriptors for @backDeployed properties #67982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed properties. The property descriptors of `@backDeployed` properties aren't available on OSes prior to the "back deployed before" OS version, so the descriptors cannot be referenced by clients that may run against older versions of the library that defines the property. See swiftlang#59214 for prior art. Resolves rdar://106517386
|
@swift-ci please test |
jckarter
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Since the current Swift runtime doesn't properly check for a weak-linked external property descriptor, this looks good for now. For future runtimes, it would be good to also fix the runtime so we can still use the weak-linked property descriptor in case the API does evolve beyond what the back-deployed implementation provides. But we'd still only be able to take advantage of that on newer OSes, so we'd still need to fall back to the behavior you have implemented here for current and older OS deployment targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property descriptors of
@backDeployedproperties aren't available on OSes prior to the "back deployed before" OS version, so the descriptors cannot be referenced by clients that may run against older versions of the library that defines the property.See #59214 for prior art.
Resolves rdar://106517386