[5.7] Enable string processing by default. #59623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
swiftlang/swift-driver#1115 |
airspeedswift
approved these changes
Jun 22, 2022
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
Make frontend flag `-enable-experimental-string-processing` default to true.
|
@swift-ci please test |
|
@swift-ci test |
Swift(linux-x86_64) :: Index/Store/cross-import-overlay.swift
Swift(linux-x86_64) :: ScanDependencies/bin_mod_import.swift
Swift(linux-x86_64) :: SourceKit/DocSupport/doc_cross_import_common.swift
Swift(linux-x86_64) :: SourceKit/DocSupport/doc_internal_closure_label.swift
Swift(linux-x86_64) :: SourceKit/DocSupport/doc_swift_module_cross_import.swift
Swift(linux-x86_64) :: SourceKit/DocSupport/doc_system_module_underscored.swift
Swift(linux-x86_64) :: SourceKit/InterfaceGen/gen_swift_module.swift
Swift(linux-x86_64) :: SourceKit/InterfaceGen/gen_swift_module_cross_import.swift
Swift(linux-x86_64) :: SourceKit/InterfaceGen/gen_swift_module_cross_import_common.swiftLooks like most of these are related to cross-import overlays. I looked into it for a while and couldn't figure out why. Some test outputted "_StringProcessing" in the import list but not "_Concurrency", and yet those tests have neither |
|
Looking forward to this 😉 Would be nice to stop special casing on linux builds :-) |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
|
@swift-ci test |
|
@swift-ci Please test |
This is some groundwork to make it possible to flip the `-enable-experimental-string-processing` flag on by default if and when it passes Swift Evolution. This PR itself do **not** change the defaults. - Do not implicitly import _StringProcessing when building a module interface. - Do not implicitly import _StringProcessing when core libraries, same as _Concurrency.
don't import string processing
|
@swift-ci please test |
stephentyrone
added a commit
that referenced
this pull request
Nov 2, 2022
* Merge pull request #59623 from rxwei/cherry-42611 * Fixup switch.swift test from bad merge. Co-authored-by: Richard Wei <[email protected]>
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Nov 9, 2022
…#61793) * Merge pull request swiftlang#59623 from rxwei/cherry-42611 * Fixup switch.swift test from bad merge. Co-authored-by: Richard Wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #42611.
Make frontend flag
-enable-experimental-string-processingdefault to true.