Skip to content

Strip Sendable from existential types in @preconcurrency mangling. #59636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2022
Merged

Strip Sendable from existential types in @preconcurrency mangling. #59636

merged 1 commit into from
Jun 22, 2022

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jun 22, 2022 •
edited
Loading

  • Explanation: Fixes an ABI bug where @preconcurrency doesn’t eliminate Sendable from existential types or existential meta types, causing mangled name changes when Swift frameworks adopt Sendable.
  • Scope of Issue: Affects APIs that have added Sendable existential types and are marked @preconcurrency.
  • Origination: With the original implementation of @preconcurrency.
  • Risk: Low. This extends existing logic to drop Sendable from generic requirements to also modify existentials.
  • Original pull request: Strip Sendable from existential types in @preconcurrency mangling. #59635
  • Bug: rdar://91966505.

@DougGregor DougGregor requested a review from a team as a code owner June 22, 2022 06:58
@DougGregor
Copy link
Member Author

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor mentioned this pull request Jun 22, 2022
Merged
@DougGregor DougGregor merged commit 7d12ed0 into swiftlang:release/5.7 Jun 22, 2022
@DougGregor DougGregor deleted the strip-sendable-existential-preconcurrency-5.7 branch June 22, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @airspeedswift