Skip to content

Drop 'Sendable' when converting to Clang types. #59639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2022
Merged

Drop 'Sendable' when converting to Clang types. #59639

merged 3 commits into from
Jun 22, 2022

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jun 22, 2022 •
edited
Loading

  • Explanation: Fixes an IR generation bug where adopting Sendable as part of the existential result of an Objective-C method would cause the compiler to crash.
  • Scope of Issue: Affects Objective-C methods or properties that have added Sendable to their existential result/parameter types.
  • Origination: With the implementation of Sendable in Objective-C.
  • Risk: Low. This extends the logic mapping Swift existential types to Objective-C by stripping off Sendable, building on the logic introduced by Strip Sendable from existential types in @preconcurrency mangling. #59636.
  • Original pull request: Drop 'Sendable' when converting to Clang types.  #59638
  • Bug report: rdar://94824682.

@DougGregor DougGregor requested a review from a team as a code owner June 22, 2022 08:01
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor force-pushed the drop-sendable-clang-type-5.7 branch from da7eaf8 to 8811c41 Compare June 22, 2022 08:03
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit fd0d6d9 into swiftlang:release/5.7 Jun 22, 2022
@DougGregor DougGregor deleted the drop-sendable-clang-type-5.7 branch June 22, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @airspeedswift