[1/3][Distributed] Make distributed thunks the witnesses, fix calls on generic DAs #59711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
wip-generic-distributed-call-clean
branch
from
d723fc2 to
bacc5bf
Compare
ktoso
force-pushed
the
wip-generic-distributed-call-clean
branch
from
bacc5bf to
1bfe1ca
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
ktoso
force-pushed
the
wip-generic-distributed-call-clean
branch
4 times, most recently
from
eedc751 to
203a190
Compare
ktoso
commented
Jun 27, 2022
| @@ -4791,6 +4791,9 @@ ERROR(distributed_actor_func_static,none, | |||
| ERROR(distributed_actor_func_not_in_distributed_actor,none, | |||
| "'distributed' method can only be declared within 'distributed actor'", | |||
| ()) | |||
| ERROR(distributed_method_requirement_must_be_async_throws,none, // FIXME(distributed): this is an implementation limitation we should lift | |||
There was a problem hiding this comment.
marked all sites where we emit this with rdar://95949498
ktoso
force-pushed
the
wip-generic-distributed-call-clean
branch
from
203a190 to
1e87ea7
Compare
ktoso
force-pushed
the
wip-generic-distributed-call-clean
branch
from
1e87ea7 to
22b20af
Compare
|
@swift-ci please smoke test |
ktoso
requested review from
DougGregor and
xedin
and removed request for
DougGregor
ktoso
changed the title
DougGregor
approved these changes
Jun 27, 2022
| assert(systemTy && | ||
| // NOTE: So we don't need a thunk in the protocol, we should call the underlying | ||
| // thing instead, which MUST have a thunk, since it must be a distributed func as well... | ||
| if (dyn_cast<ProtocolDecl>(DC)) { |
There was a problem hiding this comment.
Nit: s/dyn_cast/isa/ (not important)
| if (requirement.hasDecl()) { | ||
| if ((!getActorIsolation(requirement.getDecl()).isDistributedActor()) || | ||
| (isa<FuncDecl>(requirement.getDecl()) && | ||
| witness.getFuncDecl()->isDistributed())) { |
There was a problem hiding this comment.
I think the last line was meant to be requirement.getFuncDecl()->isDistributed(), i.e., is the requirement distributed.
|
Thanks for review, will address in the 3/3 PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements calls on generic distributed actors, by fixing how the witness is found: it must be the thunk.
Resolves rdar://95829405