[2/3][Distributed][Typecheck] Fix distributed func typechecks in protocols #59718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
changed the title
ktoso
force-pushed
the
wip-protocols-and-das-improved
branch
from
7eab80a to
c8c625b
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-protocols-and-das-improved
branch
from
c8c625b to
2d92d4c
Compare
ktoso
changed the title
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-protocols-and-das-improved
branch
from
2d92d4c to
fa077c1
Compare
|
@swift-ci please smoke test |
ktoso
changed the title
DougGregor
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #59711 so when looking at changes, look at this diff to see changes specific to this PR.
This PR is a bit more optional than fixing the protocol crashes;
But while I was working on that, I managed to fix a number of related issues (this PR):
These are minor fixes and can wait for a dot release if they have to.
where SerializationRequirement ==since we can apply the checks, and the protocol can only be implemented by a "matching" distributed actor