Skip to content

TempRValueOpt: don't move end_access instructions after a terminator instruction #59721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

eeckstein
Copy link
Contributor

When extending access scopes, prevent that we end up with an end_access after the block's terminator.

Fixes a verifier crash.

rdar://85020372

@eeckstein eeckstein requested a review from meg-gupta June 27, 2022 14:33
@eeckstein
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@eeckstein eeckstein force-pushed the fix-temprvalueopt branch from 8ac367d to a15b713 Compare June 27, 2022 17:51
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

…r instruction.

When extending access scopes, prevent that we end up with an `end_access` after the block's terminator.

Fixes a verifier crash.

rdar://85020372
@eeckstein eeckstein force-pushed the fix-temprvalueopt branch from a15b713 to 2eda3b3 Compare June 27, 2022 17:55
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants