Skip to content

[5.7] TempRValueOpt: don't move end_access instructions after a terminator instruction. #59733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

eeckstein
Copy link
Contributor

When extending access scopes, prevent that we end up with an end_access after the block's terminator.

Fixes a verifier crash.

rdar://85020372

This is a cherry-pick of #59721

…r instruction.

When extending access scopes, prevent that we end up with an `end_access` after the block's terminator.

Fixes a verifier crash.

rdar://85020372
@eeckstein eeckstein added the r5.7 label Jun 27, 2022
@eeckstein eeckstein requested a review from a team as a code owner June 27, 2022 21:02
@eeckstein eeckstein requested a review from meg-gupta June 27, 2022 21:02
@eeckstein
Copy link
Contributor Author

@swift-ci test

@tbkka
Copy link
Contributor

tbkka commented Jun 27, 2022

Reviewed by @meg-gupta

@eeckstein eeckstein merged commit ea32433 into swiftlang:release/5.7 Jun 28, 2022
@eeckstein eeckstein deleted the fix-temprvalueopt-5.7 branch June 28, 2022 06:53
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants