[LangOptions] Remove the option to enable/disable implicit existential opening. #59740
Conversation
|
@swift-ci please smoke test |
| @@ -8,14 +8,14 @@ protocol CP : class { } | |||
| static func createNewOne() -> SP | |||
| } | |||
|
|
|||
| func fP<T : P>(_ t: T) { } | |||
| func fP<T : P>(_ t: T?) { } | |||
There was a problem hiding this comment.
Is the addition of '?' in this file intentional?
There was a problem hiding this comment.
Yes, I made these parameters optional so the diagnostics stay the same later in the file (instead of disappearing due to opening)
in code completion to avoid sending a pre-type-checked AST through the constraint system.
|
@swift-ci please smoke test |
| // Use a placeholder expr for the LHS argument to avoid sending | ||
| // a pre-type-checked AST through the constraint system. | ||
| OpaqueValueExpr argExpr(LHS->getSourceRange(), LHSTy, | ||
| /*isPlaceholder=*/true); |
There was a problem hiding this comment.
Make sense to me! If I understand correctly, code completion doesn't care about the structure of the argument but the fact that the argument has a particular type it could use to infer right-hand side of the operator.
/cc @ahoppen
There was a problem hiding this comment.
Yes, we only care about the type. We might even be able to get rid of the ConstraintSystemFlags::ReusePrecheckedType option above. Not entirely sure though.
This feature has been accepted in Swift evolution, so there's no need to have a flag to enable/disable it. This also fixes an issue where the feature was not enabled by default in LLDB.
This change also uses opaque value placeholders where code completion was previously sending a pre-type-checked AST through the constraint system, which tripped an assertion during
shouldOpenExistentialCallArgumentwhen looking up types for AST nodes that should have been cached in the constraint system.Resolves: rdar://94730905