[ConstraintSystem] Remove ConstraintSystemFlags::ReusePrecheckedType.
#59821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that operator code completion uses opaque placeholder exprs, there's no need to pass the flag to use prechecked types in the constraint system.
|
@swift-ci Please SourceKit stress test |
|
@swift-ci please smoke test |
ahoppen
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the last use of
ConstraintSystemFlags::ReusePrecheckedTypein operator code completion, and removes the option altogether from the constraint system.Now that operator code completion uses an opaque value placeholder with the pre-checked type, code completion no longer needs to send a type checked AST through the constraint system, which was very brittle. Opaque value placeholder expressions were designed to be used as a placeholder for a fully type checked expression, making this a better approach for code completion paths that haven't yet been ported to solver-based completion.