[CS] Remove assertion that callee locator has an anchor #59997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
xedin
approved these changes
Jul 11, 2022
ahoppen
force-pushed
the
pr/empty-locator-has-no-preconcurrency
branch
from
5e6ad05 to
4201829
Compare
When computing type relations of code completion items with respect to the context they are used in, we add a `ConstraintKind::Conversion` constraint with an empty constraint locator. This currently crashes in `hasPreconcurrencyCallee`, but actually having a null anchor doesn’t produce any issues.
ahoppen
force-pushed
the
pr/empty-locator-has-no-preconcurrency
branch
from
4201829 to
ae53e8a
Compare
|
@swift-ci Please smoke test |
ahoppen
changed the title
hasPreconcurrencyCallee has no anchor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing type relations of code completion items with respect to the context they are used in, we add a
ConstraintKind::Conversionconstraint with an empty constraint locator.https://github.com/apple/swift/blob/99ee194482d6f5a26c8e95ae5dca9e47db07ad78/lib/Sema/TypeCheckConstraints.cpp#L1022
This currently crashes in
hasPreconcurrencyCallee.To fix this crash, just return
falsein these cases.This fixes a crash found by the SourceKit stress tester that was introduced by #59958.