[AST] Remove ParameterTypeFlags from ParenType and TupleType #60263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Jul 28, 2022
hamishknight
force-pushed
the
2-toil-2-tuple
branch
2 times, most recently
from
c7b6f00 to
dab78c6
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
GitHub got the wrong timestamps for the force push, correct diff is https://github.com/apple/swift/compare/dab78c634d2adfc350f8f5085fce358040a4d2c8..69f59bbc6c8b2201b64b0100a8a62bffb79775e2 |
hamishknight
commented
Aug 1, 2022
Previously we relied on `TupleTypeElt::getType` returning an `InOutType` to fail the tuple type matching logic. Instead, add logic to reject any inout arguments up-front with a more specific diagnostic. Also, while we're here, strip the `_const` parameter flag, as it's not something that needs to be considered for tuple construction.
Callers may either assert that the parameter flags are empty, or ask for them to be dropped.
SILGen shouldn't care whether or not a self parameter is wrapped in a paren with ownership.
The last clients that relied on stashing parameter type flags on these types are now gone.
hamishknight
force-pushed
the
2-toil-2-tuple
branch
2 times, most recently
from
69f59bb to
e0d8e4f
Compare
|
@swift-ci please test |
|
@hamishknight Looks great! |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last clients that relied on stashing parameter type flags on these types are now gone.