Serialization: Preserve identity of opened generic environments #60523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fix-opened-generic-environment-identity
branch
from
405ba5b to
ddf9168
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
This was referenced Aug 12, 2022
DougGregor
approved these changes
Aug 12, 2022
…generic environment
…plete() to ::forPrimary()
We used to create a new environment for each opened archetype, which is incorrect when deserializing a nested type of another opened archetype.
slavapestov
force-pushed
the
fix-opened-generic-environment-identity
branch
from
ddf9168 to
9c094c5
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization did not record the generic environment of an opened archetype at all.
If a SIL function referenced two opened archetypes
@opened(123, P) Selfand@ opened(123, P) Self.Afrom the same generic environment, we would deserialize them into two different generic environments, like@opened(123, P) Selfand@opened(321, P) Self.A, so the root archetype of@opened(321, P) Self.Awould be@opened(321, P) Selfand not@opened(123, P) Selfas expected. This would trigger an assertion when collecting type-dependent operands, because this bogus root archetype was not produced by any instruction in the function.Also, clean up a few things in this area. Only the serialization commit is the bug fix; the rest should be NFC.