Serialization: Preserve identity of opened generic environments [5.7] #60525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
We used to create a new environment for each opened archetype, which is incorrect when deserializing a nested type of another opened archetype.
slavapestov
force-pushed
the
fix-opened-generic-environment-identity-5.7
branch
from
55b2478 to
aa103c9
Compare
|
@swift-ci Please test |
hborla
approved these changes
Aug 17, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization did not record the generic environment of an opened archetype at all.
If a SIL function referenced two opened archetypes @opened(123, P) Self and @ opened(123, P) Self.A from the same generic environment, we would deserialize them into two different generic environments, like @opened(123, P) Self and @opened(321, P) Self.A, so the root archetype of @opened(321, P) Self.A would be @opened(321, P) Self and not @opened(123, P) Self as expected. This would trigger an assertion when collecting type-dependent operands, because this bogus root archetype was not produced by any instruction in the function.
Cherry-picks a single commit from #60523, fixing #60347.