Skip to content

[Explicit Modules] On an explicit interface build, early exit if expected output is up-to-date. #60585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/swift/AST/DiagnosticsSema.def
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,10 @@ REMARK(cross_import_added,none,
REMARK(module_loaded,none,
"loaded module at %0",
(StringRef))

REMARK(explicit_interface_build_skipped,none,
"Skipped rebuilding module at %0 - up-to-date",
(StringRef))

WARNING(cannot_find_project_version,none,
"cannot find user version number for %0 module '%1'; version number ignored", (StringRef, StringRef))
Expand Down
3 changes: 3 additions & 0 deletions include/swift/Basic/LangOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ namespace swift {

/// Emit a remark after loading a module.
bool EnableModuleLoadingRemarks = false;

/// Emit a remark on early exit in explicit interface build
bool EnableSkipExplicitInterfaceModuleBuildRemarks = false;

///
/// Support for alternate usage modes
Expand Down
4 changes: 4 additions & 0 deletions include/swift/Option/Options.td
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,10 @@ def remark_loading_module : Flag<["-"], "Rmodule-loading">,
Flags<[FrontendOption, DoesNotAffectIncrementalBuild]>,
HelpText<"Emit a remark and file path of each loaded module">;

def remark_skip_explicit_interface_build : Flag<["-"], "Rskip-explicit-interface-build">,
Flags<[FrontendOption, DoesNotAffectIncrementalBuild]>,
HelpText<"Emit a remark if an explicit module interface invocation has an early exit because the expected output is up-to-date">;

def emit_tbd : Flag<["-"], "emit-tbd">,
HelpText<"Emit a TBD file">,
Flags<[FrontendOption, NoInteractiveOption, SupplementaryOutput]>;
Expand Down
2 changes: 2 additions & 0 deletions lib/Frontend/CompilerInvocation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,8 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,

Opts.EnableModuleLoadingRemarks = Args.hasArg(OPT_remark_loading_module);

Opts.EnableSkipExplicitInterfaceModuleBuildRemarks = Args.hasArg(OPT_remark_skip_explicit_interface_build);

llvm::Triple Target = Opts.Target;
StringRef TargetArg;
std::string TargetArgScratch;
Expand Down
Loading