Ban constructing normal conformances where the conforming type is a protocol #60716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not declared, interface type Builtin.TheTupleType's self interface type is (T...), and the declared interface type is the non-substitutable Builtin.TheTupleType.
…protocol Unlike structs, enums and classes, protocols should not have a conformance lookup table with normal conformances in it.
slavapestov
force-pushed
the
ban-normal-conformances-of-protocols
branch
from
6611b25 to
50aaaa4
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 24, 2022
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not.
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 24, 2022
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not. rdar://99096663
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 24, 2022
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not. rdar://99096663
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 24, 2022
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not. rdar://99096663
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 26, 2022
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not. rdar://99096663
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Aug 27, 2022
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not. rdar://99096663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ModuleDecl::lookupConformance() never returned a NormalProtocolConformance when given a protocol type, the conformance lookup table operations were more than happy to construct one directly if called on a protocol as the nominal type declaration. This could even trigger conformance checking, which would fail in odd ways when trying to derive type witnesses for example.
This represents wasted work and potential crashes from constructing a representation of something we never intended to exist.
One consequence is that the API digester and symbol graph model protocol inheritance as "conformances" in their schemas, which feels wrong, but I maintained the exact behavior by adding a bit of extra boilerplate at various call sites.