[SourceKit] Fix a crash because the API for retrieving intherited protocols of a ProtocolDecl changed #60751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Makes sense. I debated allowing getAllProtocols() to return the transitive closure of getInheritedProtocols(), but wanted to add the assert there first to find the usages and see if anything they did could be expressed in a simpler way. We can refactor it later as needed though.
…tocols of a ProtocolDecl changed swiftlang#60716 changed `NominalTypeDecl::getAllProtocols` to no longer work on `ProtocolDecl`. Add a new wrapper to Refactoring.cpp that dispatches to either `getInheritedProtocols` or `getAllProtocols` depending on whether the type is a protocol or not. rdar://99096663
ahoppen
force-pushed
the
pr/rdar99096663
branch
from
6fbcaac to
8f421a7
Compare
|
@swift-ci Please smoke test |
rintaro
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60716 changed
NominalTypeDecl::getAllProtocolsto no longer work onProtocolDecl. Add a new wrapper to Refactoring.cpp that dispatches to eithergetInheritedProtocolsorgetAllProtocolsdepending on whether the type is a protocol or not.rdar://99096663