[ConstraintSystem] Remove conjunction printing and iterate over all disjunction choices in scope #60762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested changes
Aug 25, 2022
amritpan
force-pushed
the
iterate-over-disjunction
branch
3 times, most recently
from
2ad4892 to
bd02f95
Compare
xedin
reviewed
Aug 25, 2022
amritpan
force-pushed
the
iterate-over-disjunction
branch
from
bd02f95 to
8962329
Compare
added 2 commits
August 25, 2022 15:19
Print all disjunctions in scope, not just the one selected. Remove conjunction printing.
…tions. Moved `debugLogger` into each if-block so it's indentation doesn't affect next `isDebugMode`.
amritpan
force-pushed
the
iterate-over-disjunction
branch
from
8962329 to
f683c2c
Compare
xedin
approved these changes
Aug 25, 2022
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints all of the inactive disjunction choices in the constraint system for the Component Step instead of just the selected disjunction for the attempt. Additionally, conjunction printing is removed as conjunction constraints do not have type variables to list.
This is an edit to #59971.