WIP: [importer] Adjust for new dependency scanner API #60882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry #60807 introduced a merge conflict here. |
jansvoboda11
force-pushed
the
jan_svoboda/cherry-pick
branch
2 times, most recently
from
253c29b to
5a066d2
Compare
artemcm
approved these changes
Sep 16, 2022
This is, in fact, not good to land. |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 26, 2022
…s with the output path. swiftlang/swift#60882 adds functionality to the Clang scan-deps invocation that produces placeholder paths as '<replace-me>'s in the generated command-line. The first step to adapting to these changes is to teach the driver to substitute the expected file paths. Once the scanner changes land, we will revisit the driver specifying these paths in favour of having the scanning action being able to determine the correct output location from the get-go.
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 26, 2022
…s with the output path. swiftlang/swift#60882 adds functionality to the Clang scan-deps invocation that produces placeholder paths as '<replace-me>'s in the generated command-line. The first step to adapting to these changes is to teach the driver to substitute the expected file paths. Once the scanner changes land, we will revisit the driver specifying these paths in favour of having the scanning action being able to determine the correct output location from the get-go.
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 26, 2022
…s with the output path. swiftlang/swift#60882 adds functionality to the Clang scan-deps invocation that produces placeholder paths as '<replace-me>'s in the generated command-line. The first step to adapting to these changes is to teach the driver to substitute the expected file paths. Once the scanner changes land, we will revisit the driver specifying these paths in favour of having the scanning action being able to determine the correct output location from the get-go.
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 26, 2022
…s with the output path. swiftlang/swift#60882 adds functionality to the Clang scan-deps invocation that produces placeholder paths as '<replace-me>'s in the generated command-line. The first step to adapting to these changes is to teach the driver to substitute the expected file paths. Once the scanner changes land, we will revisit the driver specifying these paths in favour of having the scanning action being able to determine the correct output location from the get-go.
This was referenced Sep 26, 2022
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 27, 2022
As of swiftlang/swift#60882 and swiftlang/swift#61303, emit-pcm will accept clang frontend arguments with '-Xcc', instead of clang driver arguments.
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 27, 2022
As of swiftlang/swift#60882 and swiftlang/swift#61303, emit-pcm will accept clang frontend arguments with '-Xcc', instead of clang driver arguments.
artemcm
force-pushed
the
jan_svoboda/cherry-pick
branch
from
5a066d2 to
47db857
Compare
artemcm
force-pushed
the
jan_svoboda/cherry-pick
branch
2 times, most recently
from
5a066d2 to
80440ee
Compare
…clang frontend-only results coming from scan-deps
artemcm
force-pushed
the
jan_svoboda/cherry-pick
branch
from
80440ee to
c5bd61b
Compare
1 similar comment
|
swiftlang/llvm-project#5234 |
artemcm
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency scanner, reflecting changes made to Clang in swiftlang/llvm-project#5234.