[ClangImporter] Add a mode to create the underlying Clang 'CompilerInvocation' directly from 'cc1' arguments, bypassing the Clang driver, only in the 'emit-pcm' compilation flow. #61303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
This will be used by the driver for Explicit Module Builds once #60882 lands on top of this change. |
jansvoboda11
requested changes
Sep 26, 2022
artemcm
force-pushed
the
DirectCC1ExplicitPCMBuild
branch
from
297e4f9 to
6db8317
Compare
|
@swift-ci test |
artemcm
force-pushed
the
DirectCC1ExplicitPCMBuild
branch
from
6db8317 to
8d482cf
Compare
|
@swift-ci smoke test |
jansvoboda11
approved these changes
Sep 27, 2022
benlangmuir
reviewed
Sep 27, 2022
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 27, 2022
As of swiftlang/swift#60882 and swiftlang/swift#61303, emit-pcm will accept clang frontend arguments with '-Xcc', instead of clang driver arguments.
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 27, 2022
As of swiftlang/swift#60882 and swiftlang/swift#61303, emit-pcm will accept clang frontend arguments with '-Xcc', instead of clang driver arguments.
…vocation' directly from 'cc1' arguments, bypassing the Clang driver, only in the 'emit-pcm' compilation flow. Controlled with a new flag '-direct-clang-cc1-module-build' This will allow clients to formulate 'swift-frontend' invocations with fully-specified set of cc1 arguments (using '-Xcc -Xclang -Xcc <FLAG>') required for the PCM build, without having to go through the driver.
artemcm
force-pushed
the
DirectCC1ExplicitPCMBuild
branch
from
8d482cf to
bfa6375
Compare
|
@swift-ci smoke test |
|
Thanks @benlangmuir ! |
benlangmuir
approved these changes
Sep 27, 2022
|
@swift-ci smoke test Linux platform |
|
@swift-ci smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controlled with a new flag
-direct-clang-cc1-module-buildThis will allow clients to formulate 'swift-frontend' invocations with fully-specified set of cc1 arguments (using
-Xcc <FLAG>) required for the PCM build, without having to go through the driver.When
-direct-clang-cc1-module-buildis specified,ClangImporter::createClangInvocationwill now use Clang'sclang::CompilerInvocation::CreateFromArgsdirectly with the provided CC1 flags, instead of going through the driver via Clang'sclang::createInvocationFromCommandLine.