[cxx-interop] Drop return values of +=, -=, *=, /=
#61543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-drop-return-type
branch
from
15f026c to
0de694f
Compare
|
@swift-ci please smoke test |
These operators return `Void` in Swift, let's drop the return type of these operators when importing them from C++. This is needed for the upcoming `UnsafeCxxRandomAccessIterator` protocol: if a protocol declares `func +=` returning `Void`, but the implementation non-`Void`, that causes a typechecker error.
egorzhdan
force-pushed
the
egorzhdan/cxx-drop-return-type
branch
from
0de694f to
954e740
Compare
|
@swift-ci please smoke test |
|
This is a requirement for #61554 |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operators return
Voidin Swift, let's drop the return type of these operators when importing them from C++.This is needed for the upcoming
UnsafeCxxRandomAccessIteratorprotocol: if a protocol declaresfunc +=returningVoid, but the implementation non-Void, that causes a typechecker error.