[cxx-interop] Add CxxRandomAccessCollection protocol
#61554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-random-access-collection
branch
from
0e52c17 to
4a93e95
Compare
|
@swift-ci please smoke test |
This helps to bridge C++ random access collections, such as `std::vector` and `std::string`, to Swift by conforming them to `Swift.RandomAccessCollection`
egorzhdan
force-pushed
the
egorzhdan/cxx-random-access-collection
branch
from
4a93e95 to
bc16131
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
zoecarver
approved these changes
Oct 17, 2022
|
It will be interesting to see how this changes any std::vector benchmarks (maybe we should add some more). |
|
And I assume you'll add automatic conformance in a follow up patch? |
|
Sure, I'll add automatic conformances in another patch. |
|
@swift-ci please benchmark |
|
benchmark is disabled for now so you won't get results |
hyp
reviewed
Oct 17, 2022
hyp
reviewed
Oct 17, 2022
hyp
reviewed
Oct 17, 2022
hyp
reviewed
Oct 17, 2022
hyp
reviewed
Oct 17, 2022
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to bridge C++ random access collections, such as
std::vectorandstd::string, to Swift by conforming them toSwift.RandomAccessCollection.