Skip to content

[NFC] github: Add code owners for some components #62210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 8, 2023

Conversation

AnthonyLatsis
Copy link
Collaborator

I’m an external contributor, so this is highly subjective and unrefined. Please share your thoughts and let me know if you want to be included or excluded from anywhere, or if I’ve missed something! Especially you, Suyash, since I haven’t included you anywhere yet.

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable start!

@ktoso
Copy link
Contributor

ktoso commented Nov 22, 2022

If we'd be able to I'd love to utilize this to be notified about all Distributed changes, though as they're pretty spread out, it'd have to cover all these:

./include/swift/AST/DistributedDecl.h
./include/swift/SILOptimizer/Utils/DistributedActor.h
./lib/AST/DistributedDecl.cpp
./lib/IRGen/GenDistributed.cpp
./lib/IRGen/GenDistributed.h
./lib/SILGen/SILGenDistributed.cpp
./lib/SILOptimizer/Utils/DistributedActor.cpp
./lib/Sema/CodeSynthesisDistributedActor.cpp
./lib/Sema/DerivedConformanceDistributedActor.cpp
./lib/Sema/TypeCheckDistributed.cpp
./lib/Sema/TypeCheckDistributed.h

can we glob this like lib/Sema/.*Distributed.*, lib/IRGen/.*Distributed.* etc... And the simple ones like stdlib/public/Distributed/ test/Distributed.

Though this can be done later, just asking if such globbing would work or not?

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Nov 22, 2022

@ktoso No worries, I’ll see to it. Thanks for reacting!

@AnthonyLatsis
Copy link
Collaborator Author

just asking if such globbing would work or not

Sorry, missed this part. Yes, that will work, except in a slightly different format, like a .gitignore.

@theblixguy
Copy link
Collaborator

Especially you, Suyash, since I haven’t included you anywhere yet.

For now I don't want to be mentioned anywhere, but perhaps in the near future I will request to be added to some files 😄

@AnthonyLatsis AnthonyLatsis changed the title [NFC] Add code owners for .github, some docs, and Sema [NFC] Add code owners for some components Nov 28, 2022
@AnthonyLatsis AnthonyLatsis changed the title [NFC] Add code owners for some components [NFC] github: Add code owners for some components Nov 28, 2022
@AnthonyLatsis AnthonyLatsis requested review from ktoso and xedin November 28, 2022 16:32
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Nov 28, 2022

@ktoso Have I missed anything (see the last commit)?

@xedin Could you have another look at this? I have tuned ownership in some areas and added quite a bit to address feedback.


Note that I am deliberately adding sections per component or directory rather than per feature, e.g. I did not add a "Distributed owners" section. There are several reasons:

  • If we keep adding code owners per feature, it will become a lot harder to
    • track what has and has not been covered
    • spot ownership-breaking additions due to the "last matching pattern" rule.
  • The way I imagine this to work is that we add default code owners for everything inside a directory and tune ownership with respect to the current file hierarchy under those directories.

@ktoso
Copy link
Contributor

ktoso commented Nov 28, 2022

Thank you, this looks very good :) The rationale on how we add those also makes sense, thanks!

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

/include/swift/AST/ @hborla @slavapestov @xedin
/include/swift/AST/*Conformance* @slavapestov
/include/swift/AST/*Distributed* @ktoso
/include/swift/AST/Evaluator* @CodaFi @slavapestov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodaFi Do you want to be mentioned to any of these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@AnthonyLatsis
Copy link
Collaborator Author

@slavapestov Do you have any objections concerning the areas I have assigned you to?

@AnthonyLatsis
Copy link
Collaborator Author

@hborla ping

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis merged commit f72816e into swiftlang:main Jan 8, 2023
@AnthonyLatsis AnthonyLatsis deleted the codeowners-sema branch January 8, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants