-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[NFC] github: Add code owners for some components #62210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a reasonable start!
If we'd be able to I'd love to utilize this to be notified about all
can we glob this like Though this can be done later, just asking if such globbing would work or not? |
@ktoso No worries, I’ll see to it. Thanks for reacting! |
Sorry, missed this part. Yes, that will work, except in a slightly different format, like a |
For now I don't want to be mentioned anywhere, but perhaps in the near future I will request to be added to some files 😄 |
15047b1
to
d0376fc
Compare
@ktoso Have I missed anything (see the last commit)? @xedin Could you have another look at this? I have tuned ownership in some areas and added quite a bit to address feedback. Note that I am deliberately adding sections per component or directory rather than per feature, e.g. I did not add a "Distributed owners" section. There are several reasons:
|
d0376fc
to
0d53ab8
Compare
Thank you, this looks very good :) The rationale on how we add those also makes sense, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thank you!
/include/swift/AST/ @hborla @slavapestov @xedin | ||
/include/swift/AST/*Conformance* @slavapestov | ||
/include/swift/AST/*Distributed* @ktoso | ||
/include/swift/AST/Evaluator* @CodaFi @slavapestov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodaFi Do you want to be mentioned to any of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
@slavapestov Do you have any objections concerning the areas I have assigned you to? |
@hborla ping |
0d53ab8
to
90c9cc7
Compare
@swift-ci please smoke test |
I’m an external contributor, so this is highly subjective and unrefined. Please share your thoughts and let me know if you want to be included or excluded from anywhere, or if I’ve missed something! Especially you, Suyash, since I haven’t included you anywhere yet.