Skip to content

[SE-0368] StaticBigInt #40722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 6, 2022
Merged

[SE-0368] StaticBigInt #40722

merged 7 commits into from
Dec 6, 2022

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented Jan 3, 2022 •
edited
Loading

@benrimmington benrimmington added the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Jan 3, 2022
stephentyrone
stephentyrone reviewed Jan 4, 2022
View reviewed changes
@benrimmington benrimmington force-pushed the staticbigint branch 2 times, most recently from 3a60fff to 581ebdf Compare January 8, 2022 17:43
@benrimmington benrimmington force-pushed the staticbigint branch 3 times, most recently from 0b7a4a9 to 3cbc153 Compare January 24, 2022 05:54
@benrimmington benrimmington force-pushed the staticbigint branch 2 times, most recently from 026279f to af64b08 Compare February 2, 2022 14:43
@swiftlang swiftlang deleted a comment from swift-ci Apr 18, 2022
@benrimmington benrimmington force-pushed the staticbigint branch 4 times, most recently from d08b561 to e8b4275 Compare April 29, 2022 19:08
@benrimmington benrimmington force-pushed the staticbigint branch 2 times, most recently from 03820d6 to 9a5afbe Compare May 6, 2022 08:32
@benrimmington benrimmington force-pushed the staticbigint branch 2 times, most recently from 377b82b to 304259e Compare July 2, 2022 19:08
@benrimmington benrimmington changed the title [stdlib] StaticBigInt [SE-0368] StaticBigInt Aug 8, 2022
@benrimmington benrimmington added swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process and removed swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review labels Aug 30, 2022
amartini51
amartini51 approved these changes Sep 8, 2022
View reviewed changes
@benrimmington
Copy link
Contributor Author

I'd appreciate any help in getting this merged.

  • Commits 39b34a2 and 5488861 are for the Builtin functions.

  • The other commits are for the Swift wrapper type.
    Commit 0566537 has only been tested on x86_64.

@xwu
Copy link
Collaborator

xwu commented Nov 14, 2022

cc @stephentyrone

@benrimmington benrimmington requested review from hborla, slavapestov and xedin and removed request for eeckstein, tbkka, atrick and aschwaighofer November 29, 2022 13:14
@benrimmington
Copy link
Contributor Author

(Requesting reviews of AST and IRGen files, from code owners in #62210.)

@benrimmington
Copy link
Contributor Author

@swift-ci Please test

rjmccall
rjmccall approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler side of this looks fine.

@benrimmington benrimmington merged commit 0b29450 into swiftlang:main Dec 6, 2022
@benrimmington benrimmington deleted the staticbigint branch December 6, 2022 21:59
@etcwilde
Copy link
Member

etcwilde commented Dec 6, 2022 •
edited
Loading

@benrimmington It looks like this broke the Standard Library build: https://ci.swift.org/job/oss-swift-test-stdlib-with-toolchain-minimaln//3006

/Users/ec2-user/jenkins/workspace/oss-swift-test-stdlib-with-toolchain-minimaln/swift/stdlib/public/core/StaticBigInt.swift:76:10: error: module 'Builtin' has no member named 'isNegative_IntLiteral'
    Bool(Builtin.isNegative_IntLiteral(_value))
         ^~~~~~~ ~~~~~~~~~~~~~~~~~~~~~
/Users/ec2-user/jenkins/workspace/oss-swift-test-stdlib-with-toolchain-minimaln/swift/stdlib/public/core/StaticBigInt.swift:97:9: error: module 'Builtin' has no member named 'bitWidth_IntLiteral'
    Int(Builtin.bitWidth_IntLiteral(_value))
        ^~~~~~~ ~~~~~~~~~~~~~~~~~~~
/Users/ec2-user/jenkins/workspace/oss-swift-test-stdlib-with-toolchain-minimaln/swift/stdlib/public/core/StaticBigInt.swift:129:7: error: module 'Builtin' has no member named 'wordAtIndex_IntLiteral'
      Builtin.wordAtIndex_IntLiteral(_value, wordIndex._builtinWordValue)
      ^~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

etcwilde added a commit that referenced this pull request Dec 6, 2022
@etcwilde
Revert "[SE-0368] StaticBigInt (#40722)"
15b2322 
This reverts commit 0b29450.
@etcwilde etcwilde mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwu xwu xwu approved these changes

@glessard glessard glessard approved these changes

@lorentey lorentey lorentey approved these changes

@rjmccall rjmccall rjmccall approved these changes

@amartini51 amartini51 amartini51 approved these changes

@stephentyrone stephentyrone Awaiting requested review from stephentyrone

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benrimmington @xwu @etcwilde @glessard @lorentey @stephentyrone @rjmccall @amartini51