Skip to content

Revert "[SE-0368] StaticBigInt" #62424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented Dec 6, 2022

Reverts #40722

This caused the minimal toolchain build to fail: https://ci.swift.org/job/oss-swift-test-stdlib-with-toolchain-minimaln//3006

@etcwilde
Copy link
Member Author

etcwilde commented Dec 6, 2022

@swift-ci please smoke test

Copy link
Contributor

@benrimmington benrimmington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the failure. Should files using the new builtins have #if compiler(>=5.8) guards?

@glessard
Copy link
Contributor

glessard commented Dec 6, 2022

A thought (and shot in the dark): the minimal toolchain does not have any of the 128-bit types. I had a failure on the minimal toolchain bot when I included a test of a SIMD type for loadUnaligned().

@etcwilde
Copy link
Member Author

etcwilde commented Dec 6, 2022

It's affecting the non-minimal standard library build too: https://ci.swift.org/job/oss-swift-test-stdlib-with-toolchain//3006

@benrimmington
Copy link
Contributor

Looking at the build logs, the latest snapshot (2022-12-05) is being downloaded:

[Pipeline] sh
+ /usr/bin/curl --silent https://download.swift.org/development/xcode/latest-build.yml
[Pipeline] readYaml
[Pipeline] sh
+ /usr/bin/curl --silent https://download.swift.org/development/xcode/swift-DEVELOPMENT-SNAPSHOT-2022-12-05-a/swift-DEVELOPMENT-SNAPSHOT-2022-12-05-a-osx.pkg

So are these jobs using an older toolchain (which doesn't yet have the new builtins), and will this failure resolve itself?

@benrimmington

This comment was marked as outdated.

@benrimmington
Copy link
Contributor

The latest oss-swift-package-macos job was successful.

I'd like to wait for the 2022-12-06 snapshot, and then see if the other "stdlib-with-toolchain" jobs will succeed.

@benrimmington benrimmington marked this pull request as draft December 7, 2022 09:21
@benrimmington
Copy link
Contributor

Both jobs are successfully building, when they download the 2022-12-07 snapshot:

@benrimmington benrimmington deleted the revert-40722-staticbigint branch December 9, 2022 15:59
@rjmccall
Copy link
Contributor

@benrimmington This is actually an instance of a general problem that we've come to call "condfails", and it does need to be fixed. Basically, it's important that we tolerate at least a little bit of version slop to allow old compilers to work with new SDKs. You don't have to make the functions actually work with the old compiler — it's not usually possible — but you do need to allow the module to compile. Generally you do this with #if compiler; here's an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants