[SE-0368] StaticBigInt: support older compilers #62541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rjmccall
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Like I said, you didn't really need to make the #else path work dynamically, just let it compile so that old code can build with an old compiler if it happens to see a new SDK.
Well, anyway, I don't have any objection to trying to implement it if you think these implementations are valid, but I'm not going to bother reviewing them to figure that out. Your use of conditionals looks right, thank you.
This comment was marked as outdated.
This comment was marked as outdated.
|
@swift-ci Please smoke test |
|
The oss-swift-test-stdlib-with-toolchain job is failing again, until the next snapshot is available to download. The oss-swift-test-stdlib-with-toolchain-minimaln job is succeeding, because stdlib/StaticBigInt.swift is unsupported. |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Dec 16, 2022
ando-huang
pushed a commit
to ando-huang/swift
that referenced
this pull request
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #62424 (comment)