.github: add Threading implementation code owners
#62268
Conversation
| # Threading implementation | ||
| include/swift/Threading @al45tair | ||
| lib/Threading @al45tair |
There was a problem hiding this comment.
Could we add a leading / just to be on the safe side? And a trailing / to visually differentiate between directories and files in patterns? The latter would make it easier for humans to parse this file as it grows, I believe.
There was a problem hiding this comment.
Won't that break path matching? I imagine there was a reason not to add leading and trailing slashes for other paths not modified in this PR. Either way, I'd prefer not to modify what other people have added before here, which is out of scope for this PR, and I also don't want to make paths inconsistent in the file.
There was a problem hiding this comment.
Fair enough. No, it won’t break the matching. I think people just went with the less verbose pattern intuitively.
|
@swift-ci please smoke test |
MaxDesiatov
force-pushed
the
maxd/threading-codeowners
branch
from
88332f4 to
df6cfad
Compare
|
@swift-ci please test and merge |
Per a discussion offline, Alastair Houghton is a code owner of
lib/Threadingandinclude/swift/Threading.