Skip to content

.github: add Threading implementation code owners #62268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2022
Merged

.github: add Threading implementation code owners #62268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ lib/PrintAsClang @zoecarver @hyp @egorzhdan
stdlib/public/Cxx @zoecarver @hyp @egorzhdan
test/Interop @zoecarver @hyp @egorzhdan

# Threading implementation
include/swift/Threading @al45tair
lib/Threading @al45tair
Comment on lines +23 to +25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a leading / just to be on the safe side? And a trailing / to visually differentiate between directories and files in patterns? The latter would make it easier for humans to parse this file as it grows, I believe.

Copy link
Contributor Author

@MaxDesiatov MaxDesiatov Nov 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't that break path matching? I imagine there was a reason not to add leading and trailing slashes for other paths not modified in this PR. Either way, I'd prefer not to modify what other people have added before here, which is out of scope for this PR, and I also don't want to make paths inconsistent in the file.

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis Nov 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. No, it won’t break the matching. I think people just went with the less verbose pattern intuitively.


# Windows support
cmake/**/*Windows* @compnerd
lib/Basic/Windows @compnerd
Expand Down