[stdlib] Gardening BackDeployConcurrency files #62504
Conversation
| /// } | ||
| /// // Prints: I II III V | ||
| /// // Prints "I II III V " |
There was a problem hiding this comment.
If you think this doesn't need to be rear-spaced, just let me know.
There was a problem hiding this comment.
I think including the quotes is an improvement. It makes it easier to see that the output from print includes a space at the end.
There was a problem hiding this comment.
Good! I'll change stdlib/public/Concurrency files too and submit a new PR on the weekend. Thanks!
| @@ -22,12 +22,12 @@ extension AsyncSequence { | |||
| /// | |||
| /// In this example, an asynchronous sequence called `Counter` produces `Int` | |||
| /// values from `1` to `10`. The `dropFirst(_:)` method causes the modified | |||
| /// sequence to ignore the values `0` through `4`, and instead emit `5` through `10`: | |||
| /// sequence to ignore the values `1` through `3`, and instead emit `4` through `10`: | |||
There was a problem hiding this comment.
Note here: These numbers need to be fixed.
There was a problem hiding this comment.
Yes, the old numbers were wrong. The list starts at 1, not a 0.
| /// for await number in Counter(howHigh: 10) { | ||
| /// print(number, terminator: " ") |
There was a problem hiding this comment.
I renamed i to number just like the other examples.
There was a problem hiding this comment.
That looks like a good change to me. It's consistent, and "number" means more to the reader than "i".
|
@amartini51 Hi! Could you please review my PR like last time? #58930 |
There was a problem hiding this comment.
These changes all look good to me — thanks.
CC @invalidname
|
@swift-ci Please smoke test. |
|
Thank you both of you! 😄 @amartini51 @invalidname |
Before
Swift 5.6 concurrency librarywas separated in #59282, I revised some Concurrency files in #58930.This PR applies the revised content to the back-deployed concurrency library.
Please review! 😄