[stdlib] Correct actual print outputs in Concurrency files #62685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jager-yoo
commented
Dec 19, 2022
Comment on lines
+60
to
+61
| /// for await number in Counter(howHigh: 10) { | ||
| /// print(number, terminator: " ") |
There was a problem hiding this comment.
To be consistent with BackDeployConcurrency, I renamed i to number here.
Comment on lines
+30
to
+31
| /// for await number in Counter(howHigh: 10) { | ||
| /// print(number, terminator: " ") |
amartini51
approved these changes
Dec 20, 2022
|
@swift-ci Please smoke test. |
|
@amartini51 Thank you again! Please merge when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I corrected the actual
print(something, terminator: " ")outputs in Concurrency files, which I committed before in #58930.These changes make it easier to see that
print(something, terminator: " ")ends with a space.Back-Deployed Concurrency files have already been corrected in #62504.
Please review! cc. @amartini51 👍🏻