Skip to content

[Refactoring] Simplify excessive conditional expression: (A && !B) || (!A && B) is equivalent to bool(A) != bool(B) #62676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

valeriyvan
Copy link
Contributor

No description provided.

@hamishknight hamishknight requested a review from xedin December 19, 2022 13:09
@valeriyvan valeriyvan force-pushed the CSSimplify-simplify-condition branch from b515836 to 35c216d Compare December 19, 2022 13:21
@valeriyvan valeriyvan requested review from hamishknight and removed request for xedin December 19, 2022 13:23
@valeriyvan valeriyvan force-pushed the CSSimplify-simplify-condition branch from 35c216d to 194ecff Compare December 19, 2022 13:27
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamishknight
Copy link
Contributor

@swift-ci please test

@CodaFi CodaFi merged commit 2b27330 into swiftlang:main Dec 19, 2022
@valeriyvan valeriyvan deleted the CSSimplify-simplify-condition branch January 26, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants