[CSClosure] Fix handling of non-representivate variables #62773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the type variables referenced by a type had to be handled by `inferVariables` otherwise it would to possible to bring non-representative variable into scope which in turn later would get simplied into a variable that doesn't exist in the active scope and solver would crash. Resolves: rdar://83418797
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test Linux platform |
|
@swift-ci please test source compatibility release |
|
Source compatibility failures are unrelated and happen on |
hborla
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the type variables referenced by a type had to be handled by
inferVariablesotherwise it would to possible to bring non-representative variable into scope which
in turn later would get simplied into a variable that doesn't exist in the active scope
and solver would crash.
Resolves: rdar://83418797