[5.8][CSClosure] A couple of closure related fixes #62842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element (swiftlang#62777) * [CSSimplify] fix pattern matching logic which is as part of the enum element for closure * add test * Fixed logic to apply to N levels of nesting * update tests that take into account N levels of nesting. * fix indentation * use dynamic variables and uppdate some logic * Revert "use dynamic variables and uppdate some logic" This reverts commit 279dc4f. * fix logic to only see pattern matches * clean up unnecessary logic Co-authored-by: Luciano Almeida <[email protected]> * Clean up unnecessary logic(2) * remove dropping * Fix documentation comments to match current context * clean up unnecessary logic * remove comments Co-authored-by: Luciano Almeida <[email protected]> (cherry picked from commit 29bf82e)
All of the type variables referenced by a type had to be handled by `inferVariables` otherwise it would to possible to bring non-representative variable into scope which in turn later would get simplied into a variable that doesn't exist in the active scope and solver would crash. Resolves: rdar://83418797 (cherry picked from commit 4789369)
|
@swift-ci please test |
hborla
approved these changes
Jan 5, 2023
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #60806
Cherry-pick of #62773
Resolves: rdar://83418797
Resolves: #62777