[5.8] SILCombine: fix a crash when optimizing keypath-offset-of #62832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jckarter
requested changes
Jan 4, 2023
| // TODO: support lowering of the rootTy if it's not a legal SIL type in the | ||
| // first place, e.g. if it contains an AnyFunctionType. | ||
| if (!rootTy->isLegalSILType()) | ||
| return false; |
There was a problem hiding this comment.
Instead of skipping out on these cases, it's not that hard to handle them correctly. The lowered type of the ends of a keypath projection are always going to be the maximally-abstracted form of the formal type, so you can do
CanType rootTy = AI->getFunction()->getLoweredType(AbstractionPattern::getOpaque(),
pattern->getRootType().subst(patternSubs)->getCanonicalType());
And that should work for all root types. Even if the formal type happens to be a valid lowered SIL type, it is still a category error to use a formal type without lowering, and there could remain problems from doing so.
There was a problem hiding this comment.
ok, thanks!
-> #62862
Need to use the lowered type instead of the original type. rdar://103834325
eeckstein
force-pushed
the
fix-keypath-opt-crash-5.8
branch
from
f927a07 to
12e9aed
Compare
|
@swift-ci test |
jckarter
approved these changes
Jan 5, 2023
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to use the lowered type instead of the original type.
rdar://103834325
Cherry-picked from #62862