Skip to content

SILCombine: a better fix for optimizing keypath-offset-of #62862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

SILCombine: a better fix for optimizing keypath-offset-of #62862

merged 1 commit into from
Jan 5, 2023

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein commented Jan 5, 2023 •
edited
Loading

Instead of bailing out, use the lowered type.

rdar://103834325

This is a follow-up of #62812

@eeckstein
SILCombine: a better fix for optimizing keypath-offset-of
7c54be2 
Instead of bailing out, use the lowered type.

rdar://103834325
@eeckstein eeckstein requested a review from jckarter January 5, 2023 07:08
@eeckstein eeckstein mentioned this pull request Jan 5, 2023
Merged
@eeckstein
Copy link
Contributor Author

@swift-ci test

jckarter
jckarter approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@eeckstein eeckstein merged commit f588020 into swiftlang:main Jan 5, 2023
@eeckstein eeckstein deleted the silcombine-keypath-opt branch January 5, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeckstein @jckarter