Skip to content

[test] Reenable stdlib/StringIndex, requiring optimized_stdlib #62891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Jan 6, 2023

This test was disabled in #62875 because the addition of the new UTF-16 breadcrumbs tests seriously regressed DebugAssert runs on CI.

It turns out that even without that test, this test case is simply not appropriate to run with unoptimized stdlib builds -- e.g. the index interchange tests also take an extraordinarily long time to finish.

Let's reenable this test, but only run it with optimized stdlibs.

rdar://103934958

@lorentey
Copy link
Member Author

lorentey commented Jan 6, 2023

@swift-ci smoke test and merge

@lorentey
Copy link
Member Author

lorentey commented Jan 6, 2023

@swift-ci smoke test macOS platform

1 similar comment
@lorentey
Copy link
Member Author

lorentey commented Jan 7, 2023

@swift-ci smoke test macOS platform

@lorentey lorentey merged commit 1b92f52 into swiftlang:main Jan 7, 2023
@lorentey lorentey deleted the reenable-string-index-test branch January 7, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant