[5.8][test] Reenable stdlib/StringIndex, requiring optimized_stdlib #62892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 67f049e)
lorentey
requested review from
zoecarver,
hyp,
egorzhdan and
eeckstein
as code owners
|
@swift-ci test |
|
@swift-ci test macOS platform |
AnthonyLatsis
added
🍒 release cherry pick
|
CI builds with Debug stdlibs look fine on https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-simulators/ |
|
@swift-ci clean test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry picked from #62891)
This test was disabled in #62874 because the addition of the new UTF-16 breadcrumbs tests seriously regressed DebugAssert runs on CI.
It turns out that even without that test, this test case is simply not appropriate to run with unoptimized stdlib builds -- e.g. the index interchange tests also take an extraordinarily long time to finish.
Let's reenable this test, but only run it with optimized stdlibs.
rdar://103934958