Skip to content

[5.8][TaskLocals] Avoid use of defer in back deployed functions in the standard library #62947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 10, 2023

Cherry pick of #62946.

Older versions of the 5.8 compiler have a bug when generating SIL for functions with @_backDeploy containing defer blocks (#62444) and for now we need the standard library interface to be compatible with those older compilers.

Resolves rdar://104045168

@tshortli tshortli requested review from DougGregor and ktoso January 10, 2023 18:34
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli marked this pull request as draft January 10, 2023 18:37
…tandard library.

Older versions of the 5.8 compiler have a bug when generating SIL for functions with `@_backDeploy` containing defer blocks (swiftlang#62444) and for now we need the standard library interface to be compatible with those older compilers.

Resolves rdar://104045168
@tshortli tshortli force-pushed the avoid-defer-in-backdeployed-funcs-5.8 branch from ef27110 to 05488d7 Compare January 10, 2023 18:55
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli added swift 5.8 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 10, 2023
@tshortli tshortli marked this pull request as ready for review January 10, 2023 20:51
@tshortli tshortli changed the title [TaskLocals] Avoid use of defer in back deployed functions in the standard library [5.8][TaskLocals] Avoid use of defer in back deployed functions in the standard library Jan 10, 2023
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tshortli tshortli merged commit 83388d3 into swiftlang:release/5.8 Jan 10, 2023
@tshortli tshortli deleted the avoid-defer-in-backdeployed-funcs-5.8 branch January 10, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants