[TaskLocals] Avoid use of defer in back deployed functions in the standard library
#62946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
…tandard library. Older versions of the 5.8 compiler have a bug when generating SIL for functions with `@_backDeploy` containing defer blocks (swiftlang#62444) and for now we need the standard library interface to be compatible with those older compilers. Resolves rdar://104045168
tshortli
force-pushed
the
avoid-defer-in-backdeployed-funcs
branch
from
0ee453a to
087aacc
Compare
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
May 8, 2023
All compilers that the standard library's textual interface must support: - Allow back deployed functions to be declared without `@available`. - Allow back deployed functions to be `@inlinable`. - Support `defer` blocks in back deployed functions. We can therefore revert the workarounds added in swiftlang#62946 and swiftlang#62928. Resolves rdar://104085810
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
May 9, 2023
All compilers that must be able to compile the standard library's textual interface accept the following: - back deployed functions declared without `@available` - `@inlinable` back deployed functions - `defer` blocks in back deployed functions We can therefore revert the workarounds added in swiftlang#62946 and swiftlang#62928. Resolves rdar://104085810
nickolas-pohilets
pushed a commit
to nickolas-pohilets/swift
that referenced
this pull request
May 12, 2023
All compilers that must be able to compile the standard library's textual interface accept the following: - back deployed functions declared without `@available` - `@inlinable` back deployed functions - `defer` blocks in back deployed functions We can therefore revert the workarounds added in swiftlang#62946 and swiftlang#62928. Resolves rdar://104085810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of the 5.8 compiler have a bug when generating SIL for functions with
@_backDeploycontainingdeferblocks (#62444) and for now we need the standard library interface to be compatible with those older compilers.Resolves rdar://104045168