Skip to content

Concurrency: Revert workarounds for @backDeployed condfails #65777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented May 8, 2023

All compilers that must be able to compile the standard library's textual interface accept the following:

  • back deployed functions declared without @available
  • @inlinable back deployed functions
  • defer blocks in back deployed functions

We can therefore revert the workarounds added in #62946 and #62928.

Resolves rdar://104085810

@tshortli tshortli requested a review from ktoso May 8, 2023 21:29
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good AFAICS!

Ah ok the defer will also work now... great, thanks.

@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label May 8, 2023
All compilers that must be able to compile the standard library's textual
interface accept the following:
- back deployed functions declared without `@available`
- `@inlinable` back deployed functions
- `defer` blocks in back deployed functions

We can therefore revert the workarounds added in
swiftlang#62946 and
swiftlang#62928.

Resolves rdar://104085810
@tshortli tshortli force-pushed the clean-up-back-deployed-concurrency-apis branch from 05cb387 to 860b8cd Compare May 9, 2023 01:26
@tshortli
Copy link
Contributor Author

tshortli commented May 9, 2023

@swift-ci please test

@tshortli tshortli merged commit 1bf9424 into swiftlang:main May 9, 2023
@tshortli tshortli deleted the clean-up-back-deployed-concurrency-apis branch May 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants