Skip to content

[TaskLocals] Remove use of @inlinable with @_backDeploy temporarily #62928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 9, 2023

Resolves rdar://104012046

@tshortli tshortli requested a review from ktoso January 9, 2023 19:01
@tshortli
Copy link
Contributor Author

tshortli commented Jan 9, 2023

@swift-ci please smoke test

@tshortli
Copy link
Contributor Author

tshortli commented Jan 9, 2023

Note: we should wait until after 5.8 to reintroduce these @inlinable attributes to the stdlib.

@tshortli tshortli merged commit dcb07d9 into swiftlang:main Jan 9, 2023
@tshortli tshortli deleted the remove-inlinable-from-tasklocal-withvalue branch January 9, 2023 22:44
tshortli added a commit to tshortli/swift that referenced this pull request May 8, 2023
All compilers that the standard library's textual interface must support:
- Allow back deployed functions to be declared without `@available`.
- Allow back deployed functions to be `@inlinable`.
- Support `defer` blocks in back deployed functions.

We can therefore revert the workarounds added in
swiftlang#62946 and
swiftlang#62928.

Resolves rdar://104085810
tshortli added a commit to tshortli/swift that referenced this pull request May 9, 2023
All compilers that must be able to compile the standard library's textual
interface accept the following:
- back deployed functions declared without `@available`
- `@inlinable` back deployed functions
- `defer` blocks in back deployed functions

We can therefore revert the workarounds added in
swiftlang#62946 and
swiftlang#62928.

Resolves rdar://104085810
nickolas-pohilets pushed a commit to nickolas-pohilets/swift that referenced this pull request May 12, 2023
All compilers that must be able to compile the standard library's textual
interface accept the following:
- back deployed functions declared without `@available`
- `@inlinable` back deployed functions
- `defer` blocks in back deployed functions

We can therefore revert the workarounds added in
swiftlang#62946 and
swiftlang#62928.

Resolves rdar://104085810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant