[test] Re-enable temporary allocation IRGen testing, separating large allocation testing and making it less brittle #63095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
5 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@swift-ci test |
xwu
force-pushed
the
temporary-allocation-irgen-testing
branch
from
afceb4a to
ea6b0fe
Compare
… very large allocation test.
xwu
force-pushed
the
temporary-allocation-irgen-testing
branch
from
ea6b0fe to
4dd6e3f
Compare
|
@swift-ci test |
xwu
changed the title
|
We should take care not to let this test languish, as it's really important that we get the codegen correct for unsafe allocations. If we start getting bad codegen for whatever reason, there could be serious stability or security implications. |
grynspan
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the bots,
zeroextisn't emitted for all architectures when callingswift_stdlib_isStackAllocationSafe.Since this very large temporary allocation test is a brittle one, we'll relocate it into a separate file and noodle on it there, and we'll keep this test disabled for now with the tracking rdar. This should allow us to re-enable the remaining temporary allocation tests
Once moved to its own file, turns out that a bunch of calls in the very large temporary allocation test are also emitted as tail calls, so we'll also accommodate that change.
Partially resolves rdar104435186.