[test] Re-enable very large allocation codegen test #63188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@shahmishal, is there any good way to test this on the AArch64 Ubuntu CI platform before merging? |
|
AFAIK, I don’t think there is a way to test AArch64 Ubuntu it in PR testing. I wouldn’t take that for a definite answer though. |
|
We don't have aarch64 support available on PR testing right now, however we are able to trigger Apple Silicon testing if that help. |
|
@shahmishal I suppose it wouldn’t hurt to test, but as I understand it that wasn’t giving any trouble… I guess otherwise since all the bots are green the strategy can only be to merge and revert if necessary? |
|
Yes, let's merge and if it breaks bots, we will need to revert again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #63034, #63093, #63110, #63095.
Hopefully this completes the saga.
Resolves rdar://104435186.