Skip to content

[Serialization] Enable deserialization safety by default #63116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Jan 19, 2023

The main deserialization safety logic was completed with #63096. This PR simply turns it on by default.

rdar://99495048

@xymus xymus requested a review from bnbarham January 19, 2023 21:24
@xymus
Copy link
Contributor Author

xymus commented Jan 19, 2023

@swift-ci Please smoke test

Both of these IRGen tests expect to see internal details from resilient
modules at build time. Deserialization safety hides that information,
let's disable it to preserve the desired behavior.
@xymus
Copy link
Contributor Author

xymus commented Jan 20, 2023

Disabled deserialization safety in two tests expecting to read internal details.

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Jan 21, 2023

swiftlang/llvm-project#6060

@swift-ci Please smoke test

1 similar comment
@xymus
Copy link
Contributor Author

xymus commented Jan 23, 2023

swiftlang/llvm-project#6060

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Jan 23, 2023

@swift-ci Please smoke test Linux

@xymus
Copy link
Contributor Author

xymus commented Jan 23, 2023

@swift-ci Please smoke test macOS

@xymus xymus merged commit a0ee5c5 into swiftlang:main Jan 24, 2023
@xymus xymus deleted the deser-safety-by-default branch January 24, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants