[Debug info] Dump macro expansion buffers to disk for debug info to reference #63125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference When emitting debug info that references into a macro expansion, dump the macro expansion buffer into a file on disk (in the temporary directory) so that one can see the macro expansion buffers in the source files themselves. The test here validates that the generated LLVM IR looks correct, but I'm having a problem getting LLDB to actually locate the source code correctly.
|
@swift-ci please smoke test |
When there are no excerpts, we should assume indentation of zero.
This allows the debugger to choose whether to display the expanded macro (inlined) or the original source code (parent frame). rdar://102916513
…en to disk. This helps LLDB recognize the last line of the macro.
DougGregor
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
Note that the actual debug-info scope code is from #63144. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When emitting debug info that references into a macro expansion, dump
the macro expansion buffer into a file on disk (in the temporary
directory) so that one can see the macro expansion buffers in the
source files themselves.
And thanks to the @adrian-prantl, emit "inline call" debug scopes for macro expansion expressions. The end result of this is that LLDB can "step into" a macro expansion expression to walk through the expanded code.
Implements a big chunk of rdar://102916513.