Debug Info: Represent macro expansions as inlined functions. #63144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Jan 21, 2023
lib/SILGen/SILGenFunction.cpp
Outdated
| /*Results*/ {}, None, SubstitutionMap(), SubstitutionMap(), | ||
| SGM.M.getASTContext()); | ||
| SILFunction *MacroFn = B.getOrCreateFunction( | ||
| Loc, MacroName.getBaseIdentifier().str(), |
There was a problem hiding this comment.
Should we render the full macro name here, with argument labels? And is this something that will eventually need to be unique?
There was a problem hiding this comment.
Ideally, we should provide the fully mangled name here, then LLDB can render it appropriately. It would also be awesome to emit pattern_binding nodes for all the arguments (if we don't do that already) and associate them with macro arguments as (debug_value(_addr) %0 : $Type, let, name "arg_1", argno 1, loc ...) in SIL.
This allows the debugger to choose whether to display the expanded macro (inlined) or the original source code (parent frame). rdar://102916513
adrian-prantl
force-pushed
the
102916513
branch
from
338dd01 to
4184984
Compare
|
@swift-ci test |
|
@swift-ci test and merge |
|
This landed as part of #63125 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the debugger to choose whether to display the expanded macro
(inlined) or the original source code (parent frame).
rdar://102916513