[Distributed][CustomRuntimeAttrs] Support custom runtime attributes on distributed actors #63364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-attrs
branch
from
368451c to
079cc9c
Compare
ktoso
commented
Feb 2, 2023
ktoso
commented
Feb 2, 2023
ktoso
commented
Feb 2, 2023
ktoso
commented
Feb 2, 2023
|
Depends on #63396 |
xedin
approved these changes
Feb 3, 2023
Making sure we can use custom runtime attributes on a `distributed actor` even if only on distributed methods. It seems we can't do this on non distributed methods, as the call is made cross actor so the distributed isolation prevents it. Not sure if that should be possible anyway -- as long as distributed funcs can be annotated the most important part works <3
ktoso
force-pushed
the
wip-distributed-attrs
branch
from
d2abc38 to
12d1ebc
Compare
|
@swift-ci please smoke test and merge |
|
Updated the tests, thanks for review! I kept the compilation only one as well. |
|
@swift-ci please smoke test and merge |
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure we can use custom runtime attributes on a
distributed actoreven if only on distributed methods.It seems we can't do this on non distributed methods at least typecheck wise, but it fails in SIL -- would you be able to have a look @xedin? We should make sure we're able to annotate
distributed funcs using attributes, this would be tremendously useful in the near term for distributed.