[Mangling] Fix Runtime Attribute mangling #63396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Azoy
force-pushed
the
fix-runtime-attrs-mangling
branch
from
c78bd08 to
c2f8223
Compare
|
@swift-ci please smoke test |
xedin
approved these changes
Feb 2, 2023
|
Argh, you're right. Thanks! |
|
Would you mind giving me a ping when you merge so I can update #63364? :-) |
use here fix tests
Azoy
force-pushed
the
fix-runtime-attrs-mangling
branch
from
c2f8223 to
1535f30
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of unconditionally appending
"vp"(which means a variable), use the correct mangling for all entities that can be represented by this attribute. Also, while we're here let's shift some things around to better match current other manglings.