[cxx-interop] Avoid extra copy in CxxConvertibleToCollection
#63458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the performance of iterating over a C++ container that is automatically conformed to `CxxConvertibleToCollection` protocol by removing the extra copy of the container. This also tightens the requirements of `CxxConvertibleToCollection` by making `begin()` and `end()` non-mutating.
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
Performance (x86_64): -O
Performance (x86_64): -Osize
Performance (x86_64): -Onone
|
|
That's awesome! Do you plan on adding a compiler test as well? |
|
Yeap, I'm going to add more compiler tests for this once the hierarchy restructure patch lands (#63469). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance of iterating over a C++ container that is automatically conformed to
CxxConvertibleToCollectionprotocol by removing the extra copy of the container.This also tightens the requirements of
CxxConvertibleToCollectionby makingbegin()andend()non-mutating.